Skip to content
Submitted about 2 years ago

desktop-design

Herbilot MAVOUNGOU•40
@Herbilot
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Ouattara•200
    @Kaji17Posted about 2 years ago

    Hi @Kaji17 👋, good job for completing this challenge and welcome to the Frontend Mentor Community! 🎉

    Here are some suggestions to improve your code:

    Try to use semantic tags in your code. More information here: With semantic tags:

    <body>
   <main class="main-content">
      . . .
   </main>
   . . .
<body>

    • The profile images Alt Tags need to be improved. It should state the following; “image-qr-code“

    • I just wanted to encourage you to use rem as your main unit throughout the whole project instead of px. There's nothing wrong with pixels, but they are not as responsive as rem, especially if a user has a different font-size in their browser other than the regular 16px. click here to access converter px to rem

    • Use max-width: 15.625rem to .container selector instead of width.

    • Use padding: 1.25rem to .container selector.

    I hope that help you 😃

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord