Frontend Mentor | desktop-design coding challenge solution

Community feedback

@Kaji17

Posted almost 2 years ago

Hi @Kaji17 👋, good job for completing this challenge and welcome to the Frontend Mentor Community! 🎉

Here are some suggestions to improve your code:

Try to use semantic tags in your code. More information here: With semantic tags:

<body>
   <main class="main-content">
      . . .
   </main>
   . . .
<body>

The profile images Alt Tags need to be improved. It should state the following; “image-qr-code“
I just wanted to encourage you to use rem as your main unit throughout the whole project instead of px. There's nothing wrong with pixels, but they are not as responsive as rem, especially if a user has a different font-size in their browser other than the regular 16px. click here to access converter px to rem
Use max-width: 15.625rem to .container selector instead of width.
Use padding: 1.25rem to .container selector.

I hope that help you 😃

desktop-design