Desktop view QR code using basic HTML and CSS

Community feedback

• 

  Kafayatige•50

  @KafayatigePosted over 2 years ago

  Hello Feyisara

  Well done for completing this challenge.

  What you have done is stepping stone.

  I think you might find challenges like this easier in the future with Flex box. you can take look at the link I've shared below. It helped during my solution as I had some difficulties also.

  Flexbox makes it easy to lay items inside each other and arrange them with ease. its a parent-child relationship layout.

  [This will help you understand how flexbox works. I hope you find it useful as well. ] (https://css-tricks.com/snippets/css/a-guide-to-flexbox/)

  Cheers to more learning!!!

  Marked as helpful

  1

  ---

  

  Akanni Feyisara•110

  @Feyisara2306Posted over 2 years ago

  @Kafayatige Thank you very much sis, this is very helpful. I will check out the link

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey Omo iya mi!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="scan"> instead of <div class="scan">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  This should fix most of your accessibility issues

  • remove the height and width on your * global selector
  • also remove the height on your scan
  • You shouldnt work with fixed heights..

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  1

  ---

  

  Akanni Feyisara•110

  @Feyisara2306Posted over 2 years ago

  @Samadeen Thank you very much, this helps a lot

  0