Design comparison
SolutionDesign
Community feedback
- @adamjamesturner93Posted over 4 years ago
Source code looks good on the whole and is laid out nicely.
- Nice use of variables and mixins in your scss
Points to work on:
-
Try to avoid so many divs and use more semantic markup. Where you have
<section class="content-container">
consider making this<main ...>
then each<div class="content-container-items">
can become a<section>
. -
<li>
elements must be child elements on<ul>
tags. -
Make sure to provide helpful 'alt' tags on images. These are vital for people using screen readers or on low bandwidth connections to get a sense of the image they are unable to see.
1@ShubhamVerma1811Posted over 4 years ago@adamjamesturner93 Thanks for your feedback. I'll work on those issues.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord