Design comparison
Solution retrospective
I am learning how to develop responsive websites. I tried my best here to avoid using fixed width and height values and use dynamic units as much as I could.
Due to it, when I scale the page horizontally the size of the images reduce drastically.
How can I fix those. Thanks!
Community feedback
- @mattstuddertPosted over 4 years ago
Hey Shubham, nice work on this challenge. You'd need to add in media queries to change the layouts for different screen sizes. Without making it responsive the images will shrink way down because there isn't the space available for them to be larger. Here's a great course on responsive fundamentals by Udacity to help you learn more.
Also, I'd recommend avoiding the amount of nesting you're doing in your Sass code. Nesting is a great feature of Sass, but it can lead to unnecessarily long and highly specific CSS selectors if used incorrectly. For example, in your generated CSS you have this selector:
.content-container .content-card .content-card-person-info .person-name p. Instead, you could simply have this as.person-name p.Keep up the great work!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord