Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Desktop QR code page using flex

Karol Jaworski• 50

@KarolJaworski

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is it solved corretly or should I fix something?

Community feedback

Fer• 3,970

@fernandolapaz

Posted

Hi 👋, perhaps some of this may interest you:

HTML / ACCESSIBILITY:

  • The main content of every page (the card in this case) should be wrapped with the <main> tag.
  • Instead of wrap each element with a <div>, better to use semantic elements like <h1> or <p>.
  • This is a meaningful image and in case the user can't see it, the alt text should give a description.

CSS:

For example, here are some very common and useful ones to get you started:

* {
box-sizing: border-box;
margin: 0;
padding: 0;
}
  • You should remove width: 1440px from the body to correctly center the card on the page (the body should always occupy the entire viewport). Also it is better to use min-height: 100vh; for the body, as using height causes the page to be cut off in viewports with small height (such as mobile landscape orientation).
  • Consider using relative units like rem or em since they are better for scalable layouts. Something simple to start with would be to convert to rem (1 rem equals the font size of the root element, 16px by default). Consider this suggestion especially for the font-size.

I hope you find it useful, any questions do not hesitate 🙂

Regards,

0

Karol Jaworski• 50

@KarolJaworski

Posted

@fernandolapaz Hey, thank you for taking a moment to review my code and give me some advices, I do appreciate it. I have just replaced the divs with semantic elements and switched the font-size to rem. As for the CSS reset, I'll start using it from now on :D

Regards!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord