Desktop Order Summary Component using SCSS

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @laurel-ray 👋🏻

  I have some quick tips to help you fix the accessibility issues.

  • In your markup, <div class="container">...</div> should be <main class="container">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • For the music icon, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here.
  • Hero image should have a display: block;, it removes the line underneath the image. If you want to know what's causing it, check out the 3rd section of this video

  I hope this was helpful 👨🏻‍💻 one last thing from me, I'd suggest trying to make it responsive. Other than that, you did a superb job for the first project. Cheers 👾

  Marked as helpful

  2

  ---

  

  Laurel Ray•30

  @laurel-rayPosted about 3 years ago

  @kens-visuals Yes! This is what I needed. Thank you for the helpful links. I will go back make these corrections and try to make it responsive.

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @laurel-ray you're welcome 😇

  0
• 

  CyrusKabir•1,885

  @CyrusKabirPosted about 3 years ago

  hello my dear friend ♥ actually you did good and clean but i think in you buttons like ( cancel , change and proceed ) aren't like the main design and it's because the "" font weight "" you use

  Marked as helpful

  1

  ---

  

  Laurel Ray•30

  @laurel-rayPosted about 3 years ago

  @CyrusKabir Hi, thank you for having a look. I had trouble making the letters on the buttons and links look right and I wasn't sure why. I'll take another crack at it.

  0