[Desktop] NFT Preview Card Challenge

Community feedback

• 

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  Hello there 👋

  Congratulation on completing the challenge

  HTML 📄

  • replace <div class="attribution"> with <footer> tag to fix accessibility issues.

  • avoid using the <span> tag to display texts alone since it is used to group inline elements. you can rather use <em>, <strong> or <small> to display short text. It will improve accessibility as well

  CSS 🎨

  • It is a good practice to use CSS custom properties. learn more about it here

  • Also you have done a good job in using relative units

  Here is a quick fix to display the span element text in one line

  • In the span element replace width: fit-content; with width: 100%;

  What you could have possibly missed

  • The hover effect when hovering over the Equilibrium image.

  • the hover effect when hovering over Equilibrium #3429

  I hope this was useful 😊

  HAPPY CODING

  1

  ---

  

  Anelise Paz•30

  @anepazPosted almost 2 years ago

  @Mr-jaw Thanks for the reply! I'm taking your advice. Soon it will be updated!

  0