Desktop First with Flexbox

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work for this one. Layout in general looks fine.

  Some suggestions would be:

  • Avoid using height: 100vh on a large container like the main element, this makes the element's height limited to only the remaining viewport/screen's height. Instead, use min-height: 100vh on it, this takes full height and will expand if it needs to.
  • Remove the width: 1440px on the main element, this gives it fixed width thus creating the horizontal scrollbar at the bottom. Instead, use max-width: 1440px on it.
  • The alt value for the image should be using alt="" or empty, since it is just a vector illustration and it is just a decorative image. Also when using alt attribute, avoid using words that relates to "graphic" such as "image, icon, logo.." no need to describe it as an image, since it is already one.
  • I would personally use a tags on the proceed to payment and cancel order since the card itself is not a form where I can use button element.

  Aside from those, great work again on this one.

  0
• 

  Om Kakatkar•90

  @OmKakatkarPosted about 3 years ago

  Looks great! You can try adding some more padding (padding-bottom) below the cancel order button.

  0