Desktop first using HTML and CSS

Community feedback

• 

  Nwosa Emeka Afamefuna•240

  @NwosaEmekaPosted over 4 years ago

  Wow! Thanks thanks so much for this feedback. I will work on them.

  The first feedback I have ever received on my work and you can't imagine what it mean to me. Thank you so much! I really appreciate you taking your time to go through my work. I have been confident of my work, your feedback is a huge inspiration and morale booster to me. I appreciate you so much. Thank you

  2
• 

  Bethany•855

  @whimsicurl-creationsPosted over 4 years ago

  Nwosa, congratulations on submitting your first solution! You did a nice job matching the designs for mobile and desktop, but I do have a few recommendations to make it even better.

  1. I would make the footer text center-aligned (feels more balanced overall).
  2. Remove the overflow: hidden; property on your container class for mobile - it's cutting off the cards on the right side.
  3. To help your design scale a bit better, I'd remove the width set on the header-content class (for desktop you can set a max-width in pixels to make sure it doesn't exceed a given size, but the 32% width is really restrictive for scaling down to smaller screen sizes).
  4. Along the same lines, I would take away the margins you've set on the cards class and set a max-width in pixels for desktop. The wide margins cause all of the information on the cards to overlap.

  Keep up the good work and try another challenge or see if you want to continue working on this one more.

  2
• 

  Adarsh Pratap•5,515

  @adarshcodesPosted over 4 years ago

  Hey! @Nwosa Emeka Afamefuna, You did nice work on your first solution Congratulations. Take a look at what @whimsicurl-creations recommended, she explains everything and works on the font size too. And Keep going and keep Coding :) you're on the great learning platform with the community.

  1
• 

  Nwosa Emeka Afamefuna•240

  @NwosaEmekaPosted over 4 years ago

  Thanks @adarshcodes, I have applied those recommendations. I appreciate you and @whimsicurl-creation. Hope to learn so much from this platform

  0