Desktop first solution using css-grid and flexbox

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 3 years ago

  Hi, Sulaiman! 👋

  Very sorry for my late reply! 😅 Been a bit caught up with school and things recently! 🏫

  Great work on this challenge! 👍 Your solution looks pretty good! 😀

  A couple of small things I'd like to suggest are,

  • Writing some more descriptive text for the alt text of the main image of the card component. "The Preview Card Component Image" doesn't really say anything about what the actual content of the image is to people using screen readers. 😉
  • Wrapping the heading of the card component in a heading tag and perhaps using an article tag for the entire component (since it is a self-contained element that makes sense without additional context from a parent component). This'll just bump up the semantics of your HTML a little. 😄

  Again, these are just small points. Overall, you've done well on this challenge! 👏

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  Sulaiman Abubakar•270

  @Abu-SmanPosted over 2 years ago

  @ApplePieGiraffe Thank you so much!

  1
• 

  MD BAQTIYAR AHMED KHAN•40

  @BaqtiyarPosted almost 3 years ago

  Hover is working nice but the there is lots of CSS code you have used, try to use less code with which would be more efficient, I give this advice to myself as well.

  Marked as helpful

  1

  ---

  

  Sulaiman Abubakar•270

  @Abu-SmanPosted almost 3 years ago

  Thank you @Baqtiyar

  0