Desktop first site using HTML and CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi

  See if you can fix the issues raised by others. Also I notice the buttons are very small and lots of minor details don't match the design.

  See if you can work out how to ensure the buttons stay lined up at the bottom of the cards, no matter how much content is in there or screen size used. That is a really common thing you will have to do in real jobs.

  Good luck

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  In the html. You need to swap the buttons for anchor tags too, as their purpose is navigation. Make sure you add visible focus states to interactive elements so keyboard users know where they are on the page

  0

  

  Onoriode•20

  @didheePosted over 3 years ago

  @grace-snow

  Thank you so very kindly. I'll work on this solution again.

  Thank you.

  0
• 

  Jamie Moore•230

  @jamiem89Posted over 3 years ago

  All looks good to me. The only feedback i'd give is this: You're switching to the desktop view far too early. Between 375px and 900(ish)px, everything looks very squished in and it gets uncomfortable for a viewer to read.

  0

  ---

  

  Onoriode•20

  @didheePosted over 3 years ago

  @jamiem89

  Thank you so much. I'll work on it.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  1. look at your design in the browser
  2. now in desktop layout make your browser wide and narrow and try to find the element that is changing size the most 3.now what element is the expanding element effecting on the page
  3. now if you put a fixed height tall enough to fit the changing element so it stops changing what happens to you page

  0

  ---

  

  Onoriode•20

  @didheePosted over 3 years ago

  @palgramming

  Thank you. I'll work on it.

  0