desktop first site using flexbox with some media queries

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  nice work :)

  Marked as helpful

  2
• 

  Thomas Hertog•825

  @thomashertogPosted over 3 years ago

  please try to fix the issues in the report

  other than that, there can only be one H1 on the page (containing the page title/purpose) so think about that as well.

  the buttons seem to be semantically a hyperlink/anchor to some other page/part of the current page so these should not be button elements.

  as for the CSS, you have 3 cards that share some code, you might want to put these apart in a different class so this code can be reused.

  try not setting height explicitly, this is not necessary and will lead to trouble once you put more content in there

  1

  ---

  

  Hari haran•55

  @lionelhari010Posted over 3 years ago

  @thomashertog you mean flexbox height?

  0

  

  Thomas Hertog•825

  @thomashertogPosted over 3 years ago

  @lionelhari010 yes, but usually I never set height in general.

  1