Desktop First QR Code Component using CSS Flexbox
Design comparison
Solution retrospective
I have difficult time with the media queries and what the component should do? I just basically adjusting the margin for the mobile version, is it the right thing to do? Can you give me some advice?
Overall, what do you all think about my code structure (for the HTML and CSS)? Is there any best practice advice you can give me?
I'd love to hear your feedback...
Community feedback
- @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Here are my suggestions..
- You should use <main class="container"> instead of <div class="container">.
- You can wrap your attribution section in a footer tag to avoid accessibility issues.
This should fix most of your accessibility issues
. Regardless you did amazing... hope you find this useful... Happy coding!!!
Marked as helpful0@christian-prasetyaPosted over 2 years ago@Samadeen Well thanks, mate. That's really helpfull. Surely will change that. Cheers
0 - @GabeeeMPosted over 2 years ago
the semantics of your html and css are really good, you can use css properties like clamp and max-width to help the sizing of your elements at different viewports. that what i usually do
0@christian-prasetyaPosted over 2 years ago@GabeeeM Thank you for your feedback, and thanks for the tips.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord