Desktop first, HTML & CSS, nav toggle JS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Awesome work on this challenge! I'd give it a solid 8 👍

  As you can see in the design comparison there are a few small areas that can be improved to match up to the design. Nothing major, just small spacing, and sizing tweaks.

  You're also using h1, h3, and h5 headings with no h2 or h4. I'd recommend avoiding skipping heading levels unnecessarily. This can cause accessibility issues in the content hierarchy for screen reader users. So if you've got 3 levels in your hierarchy, you should be using h1, h2, and h3.

  I hope this helps. Keep up the great work! 🙌

  1

  ---

  

  Mladen•410

  @mladendjokovicPosted over 4 years ago

  @mattstuddert Thank you on the feedback, I really appreciate it. Didn't know the headings could cause accessibility issues, will keep that in mind.

  0