Desktop first Calc app

Community feedback

• 

  Jakub Jirous•270

  @jakubjirousPosted almost 2 years ago

  Hi Andrew,

  I have reviewed your code for this cool calculator app and here is my constructive feedback:

  HTML:

  • You have a typo in the class name coantainer. It should be container.
  • You are using an obsolete way of defining the form name attribute. Instead of name, you should use id and access the form using document.getElementById("formId").

  CSS:

  • Consider using more meaningful class names to make it easier to understand what each element represents.

  JavaScript:

  • You can use event delegation to avoid having to add event listeners to each button individually.
  • Instead of concatenating the input value, you can use the button value property to directly access the button value and append it to the input.
  • At the end, there is a little bug, when you click equal button directly, I am getting undefined on the calc screen

  Keep up the great work and happy coding!

  Marked as helpful

  1

  ---

  

  Andrew Hein•80

  @Heinz157Posted almost 2 years ago

  @jakubjirous Thank you! Very useful feedback, I will fix those things.

  0
• 

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted almost 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  LABELS 🔖:

  • input elements wants a label associated with it

  ---

  • A <label> is used to create a caption for a form control. The <label> can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute

  ---

  • Effective form labels are required to make forms accessible. The purpose of form elements such as checkboxes, radio buttons, input fields, etc, is often apparent to sighted users

  ---

  • Even if the form element is not programmatically labeled. Screen readers users require useful form labels to identify form fields.

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0