Desktop Design news homepage (yet to be responsive).

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi Finney

  • The best practise these days is to create a site using the mobile first approach, then apply media queries when there is need. Your site is not responsive, I cannot view it on mobile and any other smaller devices besides desktop. If you haven't practised that , then you need to do challenges of a lower profile for practice.
  • Most importantly , the structure of your HTML has to be revised. Some of the things to look at are as follows:

  1. the alt value of an image is meant to describe or provide the message in the image not what the image is. An alt=logo value for example describes what the image is, but what we want is to tell the user the message that is being sent with the image. If the image is decorative , then an alt="" is sufficient. The following article will give you a better insight on writing alt values image alt values
  2. The list in the navigation is a list of what? That should have been a list of anchor elements
  3. <button>Read more</button> , is this supposed to be a button or rather an anchor element. On what instances do we use an anchor element and when do we use a button. An anchor element is associated with navigation to another page or section whereas the button is meant to be used with click events (for opening modals as an example). In this challenge a button can be used in mobile view to open and close the navigation

  Marked as helpful

  0