Desing a qr code using flexbox

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  Hi, @diegodolu! 👋

  The alternative text of the QR code should describe the purpose of the QR code. You should change the alternative text.

  You should make "Improve your front-end skills by building projects" as a <h1>. Each page should have one <h1> to be an identifier or unique title for each page.

  You should add rel="noopener" to all links with target="_blank". It helps protect users of legacy browsers from security issues. Read more — Links to cross-origin destinations are unsafe

  One last thing, don't forget to fix the issues that have been reported.

  I hope this helps. Happy coding! 😄

  Marked as helpful

  0
• 

  P

  hcm•505

  @HcmwebsPosted over 1 year ago

  Hi Diego, Hola,

  It is an awesome solution, however, this is what I would improve: to the body, I would put a min-height:100vh; to center everything and no need to add the margin to the 'contenedor'. Also, I would recommend the using 'main' instead of a div with the class "contenedor", and 'footer' instead of div with the attributions class this solves your html validation report of landmarks. I hope this is of help.

  Great job. Regards,

  Marked as helpful

  0

  ---

  

  diegodolu•40

  @diegodoluPosted over 1 year ago

  @Hcmwebs Thanks a lot, I'll keep it in mind for the next challengues.

  0