Designing a (Responsive Rating Card Component) with HTML ,CSS and JS.

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Change width to max-width in your component’s container to make it responsive. You will also want to delete the height as it is unnecessary.

  • The “icons/images” in this component serve no other purpose than to be decorative; They add no value. There alt Ttag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  AbdelRahman Elrefai•190

  @ar-refaiPosted almost 2 years ago

  @vcarames thank you vcrames for your helpful comment , i did delete the height and change the width to max-width as you suggested, also I will keep in mind what you said about the proper way of designing the card using forms and "radio input" in the next challenges and hope you will help me more in the future with your comments. thank you!

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @Abdelrahman-Elrefai

  I am glad that I was able to help out!

  Keep it up!

  Marked as helpful

  1