@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Change
widthtomax-widthin your component’s container to make it responsive. You will also want to delete theheightas it is unnecessary.
- The “icons/images” in this component serve no other purpose than to be decorative; They add no value. There
alt Ttagshould be left blank and have anaria-hidden=“true”to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build this challenge is to create a
formand inside of it, the “rating buttons” should be built using aninput radio(wrap all of them inside afieldset), since this will prevent additional buttons from being active at the same time, and it should have alabelelement attached to it for accessibility.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
@ar-refai
Posted
@vcarames thank you vcrames for your helpful comment , i did delete the height and change the width to max-width as you suggested, also I will keep in mind what you said about the proper way of designing the card using forms and "radio input" in the next challenges and hope you will help me more in the future with your comments. thank you!
@VCarames
Posted
@Abdelrahman-Elrefai
I am glad that I was able to help out!
Keep it up!
Marked as helpful
