Designed this webpage using HTML and CSS

Community feedback

• 

  P

  Katrien Schuermans•1,210

  @katrien-sPosted about 4 years ago

  Actually, your code looks really good. It's clean and easy to read.

  • Next time, try to go mobile-first and work in your media-queries with min-width rather than max-width. It's good practice.
  • Your mobile-version doesn't fit on the right.
  • You need to set a 'tablet'-size media query since at some point, your design no longer fits the screen.

  Maybe a way to fix this is bring all your html in a <div class="container">and set a max-width in css. I gave mine these values:

  .container {
    width: 90vw;
    margin: 0 auto;
  }
  

  2

  ---

  

  Akash Raturi•25

  @akashraturiPosted about 4 years ago

  @graficdoctor Thanks for taking out time to comment. I'll keep those points in mind. :)

  0
• 

  Roman Filenko•3,335

  @rfilenkoPosted about 4 years ago

  Hi Akash, use flexbox or css grid for layout - those are proper techniques to position elements on a page. Would start from learning them, definately you'll use them in the future.

  Cheers, Roman

  1

  ---

  

  Akash Raturi•25

  @akashraturiPosted about 4 years ago

  @rfilenko Sure. Actually, I knew that I have to learn grid and flexbox but I just wanted to implement whatever I have learnt till now. And I think that helped me realize as to why things like grid or flexbox exists. But yeah, I'll learn them now. Thanks for your time Roman. :)

  1
• 

  M.S Ahmed•90

  @ms-ahmedPosted about 4 years ago

  The third divs get out of the scree, when the screen is sized 856px.

  1

  ---

  

  Akash Raturi•25

  @akashraturiPosted about 4 years ago

  @MansanSouleimanAhmed Yeah. Actually I didn't write the code for a tablet sized screen. Also, I just came to know that designing mobile-first is considered a better practice. So, I'll definitely keep that in mind next time. Thanks for the feedback. :)

  0