Designed qrcode challenge using html and css.

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @rakshithjodukallu, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  Remove the margin-top and align the whole content using just the body.See the code below:

  body {
      min-height: 100vh;
      background-color: #d5e1ef;
      margin-top: 200px;
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Rakshith J•240

  @rakshithjodukalluPosted about 2 years ago

  @correlucas Your code working, thanks for suggestion.

  0
• 

  Nelson Nzewi•270

  @nzewiPosted about 2 years ago

  Great solution there Rakshith J

  1.<img src="./images/image-qr-code.png" class="img-fluid" alt=""> You can add a value to the alt tag because the image is not merely decorative but conveys something meaningful.

  2.<div class="codeouter"> It would be good if you used more descriptive class names to help other developers understand your code better and also help you in the future to understand.

  3.Use <main> instead of a simple <div> . This way, you improve the semantics and accessibility of your site, showing which is the main block of content on this page. Every page should have a <main> block

  4.The main heading has the tag <h4>. You should replace it with <h1> since this heading is the main title on this page. Every page should have one <h1> to declare the most important title and you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

  Marked as helpful

  0

  ---

  

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  @nzewi Amazing and original review.

  0

  

  Rakshith J•240

  @rakshithjodukalluPosted about 2 years ago

  @nzewi I will make add these tips further design. thanks mate

  0