Skip to content
Submitted 8 months ago

Used HTML & CSS

Parbagga•40
@Parbagga
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This is my first challenge and I am happy that I was able to do it myself. .

What challenges did you encounter, and how did you overcome them?

I learned about deploying and linking the project with Github repo within the same challenge.

What specific areas of your project would you like help with?

I would appreciate the suggestions and advice by others. So that i can improve better.

Community feedback

  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    Hi @Parbagga,

    Nice Work !

    I would suggest following:-

    1.Prefer replacing <div class="card"> with <main> element.

    2.Replace <h3> with <h1> element.

    3.Understanding of the flexbox layout system will be useful in the long run.

    These will enhance your code, improve accessibility and make your markup more semantic.

    Hope these suggestions are helpful !

    Happy Coding !

    Marked as helpful
    2
    Parbagga•40
    @ParbaggaPosted 8 months ago

    Thanks for reviewing and Suggestions @Harsh-Kumar-Dwivedi

    1
    Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    @Parbagga

    Your welcome !

    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 8 months ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    QR iMAGE ALT TEXT 📸:

    • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.
    • The alt attribute should explain the purpose of the image.
    • E.g. alt="QR code to frontendmentor.io"
    <img alt="QR code to frontendmentor.io" src="./Design Files/images/image-qr-code.png">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord