Design Token based Order Summary Card

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Flexowitsch, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible add width: 25rem to .order-sum-card class
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px or % use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1
• 

  Flexowitsch•160

  @FlexowitschPosted about 2 years ago

  I only used % and rem in the :root variables. The variables are then used throughout the design. The rest i will take and adjust my code. Thx for the feedback @denielden

  1

  ---

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @Flexowitsch you are welcome and keep it up :)

  1