Design NFT preview card component using flexbox and :is()

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Abbas Roholamin,

  Congratulation on finishing this challenge. Great work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  The most important part in this challenge, you can use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not beavatrt image. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For middle part of the card class="pricing, you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  Marked as helpful

  1

  ---

  

  Abbas Roholamin•30

  @abbas-roholaminPosted about 2 years ago

  Dear @PhoenixDev22 Thanks for the valuable guidance you have given me, I will try to follow all these points in my future work

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @abbas-roholamin Glad it was helpful. Happy coding!

  0