Desafio QRcode

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @Wagner-Quaresma!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  Yagyesh mani Tripathi•140

  @YagyeshMani1498Posted 10 months ago

  @Wagner-Quaresma - hello wagner i think there are two mistakes in your code

  1. you should change the heigth:100vh in your "wirpper" container to height:100% or you can remove it there is no need to set the height property, because it will overflow on changing the height of the viewport and it will hide your contents that does not fit inside the viewport.
  2. you should add a padding to your "wripper" container so that it does stick on the top of the viewport.

  HAPPY COADING......

  Marked as helpful

  0