deisgn-qr-code-component-main

Community feedback

• 

  Ugo Francis•130

  @Vanfrankie7Posted about 1 month ago

  Great job Asledin, I noticed that in the desktop version, the container (card) is stuck at the top of the screen. No margin at the top. You could add a margin at the top to see if that would solve the issue.

  0

  ---

  

  geomydas•1,440

  @geomydasPosted about 1 month ago

  @Vanfrankie7 no no no, you should use padding instead. its using fixed heights aswell which is unresponsive and there are more issues inside the css

  0

  

  Ugo Francis•130

  @Vanfrankie7Posted about 1 month ago

  @geomydas So, is it only containers with fixed heights that margin-top is advisable for? Containers without fixed heights should be applied padding instead?

  0

  

  Asledin-max•150

  @Asledin-maxPosted about 1 month ago

  @Vanfrankie7 Thank you for your comment. I understand now what should be careful in my design and will fix it that issue.

  1

  

  geomydas•1,440

  @geomydasPosted about 1 month ago

  @Vanfrankie7 even if you use fixed-height or not, you would still use padding for this case. using fixed-height here is already unresponsive and you wouldn't need to set a height to an element in the first place. the only exception for fixed heights are small decorations that wont change such as a profile picture

  1