day3

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @nade12209!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  0
• 

  P

  Justin Green•2,770

  @jgreen721Posted 9 months ago

  Hey nice work on this! One possible suggestion is I noticed pretty specific margin values on your .okvir element. I'm guessing this was to center it but the problem with specific values is they generally don't leave much room for responsiveness(size of users screen). Applying the display:flex, alignItems:center, justifyContent:center on the body (or parent container) should fix that and then eliminate any need for the margin values. Also maybe adding a :hover effect for your buttons. Again though, nice work. The design/card itself is 👍! 🙂

  0