Hi.
Having gone through your project, here is my observation:
- there is 3 css files that you are linking in the html file, which can affect perfomance . Among other thinks it increases the load time due to the number of http request that are required to load all the CSS and secondly CSS files are render blocking such that when the browser encounters the
<link>
tag for a CSS file it pauses rendering the page until the CSS is fully processed. - It is very important to use semantic elements in your site , for example
<p id = "clearall" class="clearall header">Clear all</p>
. Since this element is supposed to clear all the fields - it is an interactive element and should therefore be a button element. - All images should have the
alt
attribute , where when the image is decorative, thealt
should be written asalt=""
and in all other instances should carry a message that is in the image . The alt value should avoid words such asimage, picture, icon
etc as those are picked up by assistive technology automatically - I see you have nested interactive elements as shown in the code below - in short interactive elements should not be nested
<button id = "interestonly-button" class = "type-button input">
<input type = "radio" id = "interestonly-check" class="type-input">
<p class = "interestonly">Interest Only</p>
</button>
- A CSS reset styles should be used , so as to keep your site look the same in almost all browsers
- The site is not responsive - I cannot view it on my mobile phone
Conclusion
The project is missing some basic fundamentals which you can improve through the Frontend Mentor Learning path. Ask for help in the discord channel as well to speed up the learnig process and check other solutions upon completing yours
Marked as helpful
@IvanFdez01
Posted
@ChamuMutezva absolutely grateful for your comment. There'll be always things missing when you learn by your own. I appreciate so much the observation, will work on it. Cheers.