Design comparison
SolutionDesign
Solution retrospective
Feedbacks are welcome, especially on the accessibility. Thanks.
Community feedback
- @alex-kim-devPosted over 4 years ago
Hey Mubaraq, great solution! Here are some of my thoughts:
- I would use
aria-label
instead of adding a span with.visually-hidden
on the buttons, your solution works perfectly though, so that's just a preference; - I would add a visually hidden
meter
element + wrap the paragraph above into alabel
for that meter, just to be sure that assistive technology will announce this part.
Good luck and have fun making the next one!
3@mubaraqwahabPosted over 4 years ago@Alex-K1m Thanks a lot! I actually used a
meter
andlabel
before, and I tested with NVDA. I changed it and used anaria-hidden
div because I felt it was redundant and quite noisy.1 - I would use
- @hariramjp777Posted over 4 years ago
Good solution brother especially using classes for accessibility such as visually-hidden..
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord