Design comparison
Solution retrospective
How's the build? Any shortcomings? If so, any advice will be appreciated. Thanks!
Community feedback
- Account deleted
Hi Bolu,
Here are some things I noticed:
-
The Fylo div expands too much - I would make it so it has a maximum width. On large displays, it looks very stretched with no content in most of it so it ends up looking a bit out of place.
-
Same thing for your alert div - It has a lot of empty space on both sides on large displays. It makes sense for your storage-tracker div to expand with screen size since it has content to fill the space, but the alert div hardly has anything in it and ends up looking out of place as well since it's mostly empty on larger screens. I love that you went with another div for the triangle part of the alert! I used an ::after for mine and I see most people do the same - This is a nice solution to it that I hadn't thought of, I will have to try that next time I'm having to do something like this!
-
Right before your layout switches to the mobile design, the fylo container has uneven spacing on the left vs the right - It might be worth adding a little bit as a baseline so it looks even on smaller screens that still fit the desktop layout. The three buttons are also not the same size, so it might be worth looking into making them all the same size.
Other than those small things, this is a fantastic solution - Well done!
0@t3ch-spawnPosted over 2 years ago@LazyDuckling Thank you so much for your feedback. This really helps a lot and I will make these changes :) Is there anyway I can contact you for advice? Like twitter?
0Account deleted@gLitCH1904 I'm glad this helps! I'm not really on social media - My email address is on my GitHub profile if you want to reach me directly, however.
Happy coding! 😊
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord