Dashboard With CSS Flex/Grid And Light/Dark Theme
Design comparison
Solution retrospective
Hey, everybody!
This was my first time creating a site with light/dark themes, it gets the theme from local Storage or the browser theme-mode itself.
i noticed a flash on reload in dark mode, Is there a solution for it.π{edite: i found the solution, it was required to get localstorage before dom-content-loaded }
feedback is welcome and appreciated π
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello, mohamedgo! π
Great job on this challenge! π Your solution looks good, responds very nicely, and the light/dark themes work well! π
Besides adding the extra feature to save the user's theme choice in local storage (like RocTanweer mentioned), I like that you made the toggle-switch keyboard-accessibleβwhich is something else that is often overlooked in this challenge! π
Keep coding (and happy coding, too)! π
1@mohamed-goharPosted over 3 years agothanks a lot @ApplePieGiraffe. I appreciate that π
1 - @RocTanweerPosted over 3 years ago
Excellent π work brother..!
There is nothing to say to you π
Usually people forget to add transition on theme toggling and saving the theme in local storage but you have done that too
Challenge : try to animate all the cards when user first redirect to the page and when they change the theme.
Good luck π€
Keep it up and happy coding π
1@mohamed-goharPosted over 3 years agoThanks so much, @RocTanweer . I'll do this challenge π Happy Coding:
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord