dark flyo landing page using CSS with hover function
Design comparison
Solution retrospective
Hiya,
I had some issues with positioning the desktop bg to to sit perfectly on the section below without shifting so any feedback on that would be great. Alway, realised that Safari through the positioning of the dektop bg off completed, not sure if there is a way to target safari only when styling but if there is please advise.
Many thanks in advance.
Happy coding :)
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi there, Chris-Ann C.! 👋
Nice to see you complete another challenge! 😀 Good work on this challenge! 👍
A few things I suggest are,
- Taking a look at your solution report and trying to clear up some of the errors that are there in order to make your solution more accessible.
- Probably only using a
<button>
or an<anchor>
tag for the button in the hero section of the page (not both), since an anchor tag styled like a button should do just fine for this purpose. 😉 - It's not very easy to add a transition to the font-weight and text-decoration properties of an element (I don't think), and as a result, the hover states for some of the items on the page that utilize those properties is a bit jumpy (and causes other elements around those elements to jump a bit, too). A better hover state (for, say, items like links) might be to change their color or use pseudo-elements to add an underline to them (both of which can be transitioned smoothly and can be used to avoid moving other elements around in the page).
Hope those tips help. 😀
Keep coding (and happy coding, too)! 😁
2@cdc2021Posted over 3 years ago@ApplePieGiraffe
Thank you so much, your tips are always so helpful 👍🏿 Solution amended to be more accessible. The suggestion on the text hover state defintely made a difference, learned something new that will stick for future challenges 😅!
Happy coding 😁
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord