Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Customer feedback using css grid

Ferabel 50

@Ferabel

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I really appreciate all kind of feedbacks. I faced alot of challenges when working on this project. I read it online that its best to start from the mobile design first, which i did but converting it back to the desktop view (grid) was where the issue started,

  1. I was unable to position it in the middle because my parent (.minibody) was no longer carrying the 5boxes along whenever i tried to position it and i never set the position to absolute.
  2. I was unable to reduce the size of the boxes to a smaller size, i tried reducing the width, height, font and all but it was not responding
  3. Between box1 and box2 i dont know why gap between them is not responding to the gap:15px i assigned it.
  4. I tried looking for an alternative as not to specifically assign width to the boxes but was not working
  5. what could be the issues and solution to a child element not responding to its parent element adjustment even though the position of the child element is not set to (position:alternative).
  6. Is it advisable to always start with the mobile view before the desktop or tablet view?

All this issues i faced when i was trying to convert the mobile view to desktop view, the mobile view is working just fine. I really appreciate all feedbacks of any kind and better approach i could have teken. Thank you very much

Community feedback

@AkoToSiJeromeEh

Posted

Hi! Great Work Out There . I noticed that the Testimonials grid is not aligned center because it is missing a CSS property, which I recommend adding to the body properties (min-heigh:100vh). This property will help align the Testimonials grid properly. I hope this suggestion works and helps. Happy coding!

Marked as helpful

2

Ferabel 50

@Ferabel

Posted

@AkoToSiJeromeEh thank you very much.it has been adjusted

0
Mahdi Ali 180

@mahdicodes1

Posted

Hi @Ferabel 👋

Here are my recommendations, specifically about getting the exact size of the sample image you asked for. Hopefully, you find them useful!

  • My strategy to get the exact size is: Start designing from larger elements to smaller ones. As mentioned by friends in the previous comments, using grid and flex is a simpler option. Then, I work on font size, line height, and characters' space.

  • Consider using rem for sizing instead of px. Take a look at these two videos: link1 and link2

  • You haven't used the h1 tag, which is essential for assistive technologies. For more information, please refer to the following resources: using-h1-tag

  • Use a meaningful name for the alt attribute in img tags. In all images, you have used "pp". you know if the image does not load, this text will show.

Happy Coding! 🙌

Marked as helpful

1

Ferabel 50

@Ferabel

Posted

@mahdicodes1

Thank you very much, I would check out the links

0
Rino 340

@Rhinozer0s

Posted

Hey @Ferabel,

I'm back and identified your gap-problem. You gave every box a specific width. Remove that and give your parent container a max-width (for example 65rem). Now every box take the given space which is provided by the columns.

This should fix it ✌️

Marked as helpful

1

@SalahShadoud

Posted

Hey There! Nice Work Done Here i have some notes that i hope it will fix all of your proplems:

  • for the centering issue, u can use min-height: 100vh; on the body element, then wrap ur HTML code with a container <div class="container"></div> ----- as setting the body element to display: flex or grid is not a good practice ----- and give it the whole height of the page then give it a display of flex or and center content inside of it like this:
height: 100vh;

//center with flex
display: flex;
justify-content: center;
align-items: center;

//center with grid
display: grid;
place-content: center; //it will center elements by the y-axis and x-axis
  • for resizing boxes, i recommend u to set the boxes sizes in the grid-column-templet property by setting a fixed size instead of giving the 3 columns auto so the boxes will take their widths form the grid instead of taking it from the width property.

  • for the gap issue, u should use the grid gap property grid-gap: rows-gap | columns-gap instead of using the gap property.

Hope this will fix all of ur issues and Happy Coding <3

Marked as helpful

1

Ferabel 50

@Ferabel

Posted

@SalahShadoud thank you very much.it has been adjusted

1
Rino 340

@Rhinozer0s

Posted

Hey, i can fix your centering issue.

Use the min-height property for the body and center the minibody with place content This sould look like this:

body{
min-height: 100vh;
display: grid;
place-content: center;
}

with min-height: 100vh; you can be sure that the body always has at least the height of the browser window. You can implement it in every project before you start styling.

and what strikes me is that you created the columns of the minibody with auto. Instead of this you can use the fr Unit. This allows you to divide the available space into as many equal sections as you like. You can read read more about this here: https://css-tricks.com/introduction-fr-css-unit/

If you have specific questions feel free to reach me out 🤝

Marked as helpful

1

Rino 340

@Rhinozer0s

Posted

@Rhinozer0s

I will solve your problem with the gap tonight after work 😉

0
Ferabel 50

@Ferabel

Posted

@Rhinozer0s thank you very much.it has been adjusted

0
Ferabel 50

@Ferabel

Posted

@Rhinozer0s ok kindly do

0
Paks 1,350

@LifeofPaks

Posted

Hey Buddy🙌🏽,

Fantastic job👍🏽. I see you still find it difficult to center a div, don't worry the confusion is normal, you'll def get better with more practice.

How to perfectly center a div

body{
display: flex;
align-items: center;
justify-content: center;
min-height: 100vh;
}

I hope this is helpful, stay consistent, focus and don't skip fundamentals

Cheers Mate🫡

Marked as helpful

1

Ferabel 50

@Ferabel

Posted

@LifeofPaks thank you very much.it has been adjusted but how were you able to get the exact size of the design

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord