Custom Dictionary app made with React.js

Community feedback

• 

  BrunoMoleta•700

  @brunomoletaPosted 7 months ago

  Hello Luciano,

  I cloned your repo to do a Code Review.

  This is the first PR, I plan to do at least one more, because this was more of a first contact with the project.

  The main thing that's hard to understand is how someone who hasn't done the project is how things are going in Search.tsx.

  It has several functions and as much as they are commented out, it's a bit confusing.

  The first thing I did was to fix the initial state of validation using:

  const [validation, setValidation] = useState<ValidationType>({
      isEmpty: true,
      isValid: false,
      isLoading: false,
      currentWord: “”,
    }); 
  

  You were using undefined if I'm not mistaken. But it's either Empty or not, Valid or not. So the state starts Empty and not Valid [...].

  At the moment the App is broken, but I'll send you the PR anyway so you can follow my line of reasoning.

  In the worst case, if another PR isn't sent and you don't want to merge, which is perfectly acceptable,

  I suggest reviewing the way this state was initialized and simplify the Search.tsx component.

  You would then have to adjust several things.

  Best regards from Brazil, Bruno

  Marked as helpful

  1