Custom CSS code

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  Centering in CSS

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  3

  ---

  

  KramLig Coder•50

  @kramlig22Posted about 2 years ago

  @vcarames Thanks, this is very helpful.

  0
• 

  Naomi Pham•180

  @naomi-phamPosted about 2 years ago

  Hi, I think for such a small project, your HTML tags are perfectly fine. I can easily locate sections in your code.

  If you have trouble naming sections, it might be helpful to take a look at Bootstrap card component. Like in this example, you can start with a high-level card, then card-header, card-body, card-footer.

  <div class="card"">
    <div class="card-header">
       <img />
    </div>
    <div class="card-body">
      <h6 class="card-subtitle">Card subtitle</h6>
      <h5 class="card-title"></h5>
      <p class="card-text"></p>
    </div>
    <div class="card-footer">
    </div>
  </div>
  

  Hope it helps 😊

  Marked as helpful

  0

  ---

  

  KramLig Coder•50

  @kramlig22Posted about 2 years ago

  @naomi-pham really help, thanks

  1