Curved sections, I really enjoyed making this. Leave advices n comment

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Chukwudobe! 👋

  For consistent format, I recommend using a code-formatter such as Prettier. It can automatically format your entire codebase. As a result, your code is much easier to read.

  Some more suggestions:

  • Logo is an important content of the page. It's not decorative, and not the one with blank alt="" text. Without that information, a screen reader user or a search engine will not know what your site/project is called.
  • I recommend taking a look at "Quick tip: Using alt text properly - The A11Y Project".
  • The "Try it free" button should be a link. For sure it is not a submit button since it is not inside the form element and there's nothing to submit.
  • The same goes for the "Get Started For Free" buttons, they should be links.
  • For your information, anchor tags are for navigation, while the button elements are for actions like opening a modal, submitting a form, toggling element, etc. It is essential to use the correct elements.
  • For the bg-section images, I recommend making background images instead. So, use CSS background properties.
  • Remove the node. and textContent attributes from the input element.
  • It looks like you are overusing the list element. I recommend taking a look at the HTML page without any styling. See if you can understand the content without making it a list.
  • Wrap the email input and the "Subscribe" button with form element. Also, it shouldn't be inside the list.

  For the CSS, only import the necessary font families. I recommend removing both @import and only choosing the necessary font families and font weights. It's also good to know that you only need one @import.

  I hope this helps! Happy coding!

  1

  ---

  

  Chukwudobe Micah Chinedu•700

  @chukwudobe-MicahPosted about 2 years ago

  @vanzasetia I wanna ask, for the "try free" button do I have to out it in a form tag? And give it an empty label? Or I just leave only the button? it doesn't have any input, do I still need to put it in a form tag?

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @chukwudobe-Micah It's a link (anchor tag, a). It is not a button.

  0

  

  Chukwudobe Micah Chinedu•700

  @chukwudobe-MicahPosted about 2 years ago

  @vanzasetia oooh that's true, I saw it as a button, I'll look into that next time.

  0
• 

  Chukwudobe Micah Chinedu•700

  @chukwudobe-MicahPosted about 2 years ago

  Thanks a lot, appreciate you. Thanks for taking time to review my work, it always help me to improve.

  0