css with html5

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Lylia, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • img element must have an alt attribute, it's very important!
  • To make it look as close to the design as possible add border-radius: 1rem to the first image
  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • after try to add a little transition on the element with hover effect

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Lylia Azzouz•80

  @liliaazzPosted almost 3 years ago

  @denielden omgg thank you so much for the feedback and I will do my best to improve the code. thanks happy coding <3

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @liliaazz You are welcome! I would really appreciate if you mark my comment as helpful if it helped you, thank you very much :)

  Marked as helpful

  0
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @liliaazz, You’ve just about got it.

  0