darryncodes• 6,430
@darryncodes
Posted
Hi Mary,
Great job on this challenge, it looks great.
And I think you've grasped BEM really well
A few minor tweaks i noticed:
- on a really wide monitor your design has shifted to the left. I'd remove
max-width: 1440px;from.body. - i'd also update
.containerbackground size tobackground-size: cover;so it can fill the whole big screen - you could add some
aria-labelto your social links to clear the accessibility report
Hope that helps
Marked as helpful
1
MaryF• 350
@Janselin
Posted
@darryncodes Thank you a lot for your time and feedback. I'll fix all the issues you mentioned!
The thing with background size is that if i use cover, it doesnt look exactly the same as the design example 😅
0
darryncodes• 6,430
@darryncodes
Posted
you're welcome @Janselin!
Ohhhh really, perhaps I'm mistaken with the background-size: cover; as I've not tried this challenge yet 😅😂
0
