Design comparison
Solution retrospective
i finally finished this project, any feedback about the main section of image and text, i think i could not style them very well.
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Emad, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that you used a
button
in which case the best option would be ana
, because in my head when a person clicks on a button written Learn More, he is not confirming a form, or something like, it will be redirected to another page, to Learn More about!To resolve do this:
<a href="/">Learn More</a>
avoid using
px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to remThe rest is great!
I hope it helps... 👍
Marked as helpful0@emadbakryPosted almost 2 years ago@AdrianoEscarabote
wow! such a helpfull reply, thank you so much mr Adriano, i appreciate it
1 - @emadbakryPosted almost 2 years ago
I fixed the problem of navbar in mobile and added an anchor tag for buttons, I think now everything is OK
0 - @idudtgfPosted almost 2 years ago
You should add a padding in the left and right to make navbar in middle and don't forget to add a hover in button "Learn more" and mobile navbar is not working
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord