Design comparison
Solution retrospective
I decided to try out my first "CSS animation" skill on this project and I really hope I didn't mess it up
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @Xtrum, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Your background is applied but it's not too similar to the design yet. Add
background-size: contain
instead ofbackground-size: cover
to make it display the size full width and center with the card vertically. Note that now is slightly different from the challenge design.Here’s the code with the modification and the image applied as background:body{ min-inline-size: 100vw; min-block-size: 100vh; background-image: url(/images/pattern-background-mobile.svg); background-size: contain; background-repeat: no-repeat; padding: 2rem; display: grid; background-color: #E1E9FF; place-content: center; }
✌️ I hope this helps you and happy coding!
Marked as helpful0 - @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
Reduce the
border-radius
of the component to better match the FEM example. -
The “Illustration” serves no other purpose than to be decorative; it adds no value. Its Alt Tag should left blank and have an aria-hidden=“true” to hide it from assistive technology.
-
Your content is not fully responsive. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord