css sizing, html divs

Community feedback

• Account deleted

  Hi there! Congratulations on successfully completing the challenge - great work! 🎉

  After reviewing your code, I have a couple of recommendations for improving its accessibility.

  Firstly, I noticed an accessibility error report related to the use of non-semantic markup. Specifically, the error report flagged that all page content should be contained by landmarks, which is not the case in your code. To address this issue, I suggest replacing the <div class="main"> element with the semantic element <main> in your index.html file. By using landmarks, you will be able to convey the structure of your page more effectively, which will improve both the accessibility and organization of your code.

  Now, onto headings. The accessibility error report I found pointed out that your code lacks a level-one heading <h1>. To fix this issue, I recommend adding a h1 element to your code that identifies and describes the main content of your page. This will help users of assistive technologies navigate your page more effectively. I also suggest adding a sr-only class to the h1 element to hide it from visual users, as this will be useful for visually impaired users who rely on screen readers.

  Overall, your solution is impressive, and I believe implementing these changes will make it even better. I hope you find this feedback helpful, and I look forward to seeing more of your work in the future. Keep up the good work! 😄

  0
• 

  Abdul Khaliq 🚀•72,460

  @0xabdulkhaliqPosted almost 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="main"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0