Design comparison
SolutionDesign
Solution retrospective
It's not clear if my use of <strong> in index.html is correct.
Community feedback
- @denieldenPosted over 2 years ago
Hi Mel, great work on this challenge! 😉
Here are a few tips for improve your code:
- remove all
margin
fromExternal
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful2 - remove all
- @SamadeenPosted over 2 years ago
Hey Mel!! Cheers 🥂 on completing this challenge.. . And Good Job Tweaking it.
Here are my suggestions
- You can use the margin property to center your card and maybe reduce the width a little bit eg: margin: 10rem auto;
- You can also read about flexbox it will make it easier to move divs around.
- You can also adjust your border-radius your image.
. Regardless you did amazing... hope you find this useful... Happy coding!!!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord