CSS對齊方式

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @NinaLiao

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • I see you use a span to wrap the bottom part of your card. I suggest something else like a div. A span is generally used to style parts of text in a p for example.

  • Try using semantic HTML elements like main, section and article.

  • You can remove the height: auto from your card. block elements already have a height: auto by default.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  0
• 

  Mani Sankar Chintagunti•0

  @Mindslayer001Posted 4 months ago

  cool nice job

  0