Design comparison
Solution retrospective
成功寫出來
What challenges did you encounter, and how did you overcome them?google & ask AI
What specific areas of your project would you like help with?目前沒有
Community feedback
- @DylandeBruijnPosted 5 months ago
@NinaLiao
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
I see you use a
span
to wrap the bottom part of your card. I suggest something else like adiv
. Aspan
is generally used to style parts of text in ap
for example. -
Try using semantic HTML elements like
main
,section
andarticle
. -
You can remove the
height: auto
from your card.block
elements already have aheight: auto
by default.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord