
Design comparison
Community feedback
- P@loki-pepePosted 3 months ago
Visually, it looks great, but you didn't make the site responsive to different sizes. You could also tweak some details such as the background color and font and image size.
Structurally, it would be best if kept your styling in a separate .css file and then linked it to your HTML. You could also use CSS variables for repeating values such as color, sizes, font styles... (although on such a small project it probably isn't necessary).
I also like to use
box-sizing: border-box
to make my life easier:*, *::before, *::after { box-sizing: border-box; }
You should definitively give this a read.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord