Skip to content
Submitted over 2 years ago

CSS Javascript

Abdullah Ajayi•70
@AbdullahAjayi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Article preview component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'll be glad if you take a look at my html code. Could it have been better if I used article tag instead of a container div to wrap all my other elements?

Community feedback

  • JESSE OGBONNA•570
    @JesseOlisaPosted over 2 years ago

    Hello Abdullah,

    Well done on completing this challenge. It looks good. Keep it up👏.

    To fix your accessibility issue, wrap your divs inside landmarks. Landmarks help assistive technology users to navigate your page easily.

    Landmark includes a header, main, footer tags, and more. So wrap your div.container inside the main tag to resolve it. I hope this helps. Cheers

    Marked as helpful
    1
    Abdullah Ajayi•70
    @AbdullahAjayiPosted over 2 years ago

    @JesseOlisa Thanks for commenting on my work. It means a lot to me. You mean instead of using div.container, I should use main instead, right?

    0
    JESSE OGBONNA•570
    @JesseOlisaPosted over 2 years ago

    @AbdullahAjayi No need to change the div.container since you have CSS style attached to it.

    Just open a main tag and put all your main contents inside including div.container

    Hope this helps

    1
    Abdullah Ajayi•70
    @AbdullahAjayiPosted over 2 years ago

    @JesseOlisa Thanks

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord