CSS illustration

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hi there👋,

  great job with the challenge overall, final result look pretty good, especially on desktop. However it doesnt seem like really responsive. You have set breakpoints for only 375px, but 375px is not supposed to be breakpoint, the design only show how it should look like when it hits that size. You should use breakpoints whenever necessary.

  • In addition, I'd say try to avoid giving fixed heights like this: height: 90vh; use only min-height when necessary, but most of the time you don't need any height. Height should be decided by the content of the container, if needed simply tweak it with paddings and margins of the contents. Fixed heights are known to cause various issues, resulting in overflowing content when data or font-sizes change.

  • Relatedly try to avoid using px, instead use the responsive rem/em units. Here is a great resource on YT for clarifying all the differences between rem/em and explain why to use them: https://www.youtube.com/watch?v=dHbYcAncAgQ

  Hope you find this feedback helpful!🤗

  Marked as helpful

  0

  ---

  

  Tobenna•610

  @tobezhanabiPosted over 1 year ago

  Thank you @visualdenniss thats one aspect i need to work on

  0