@mattstuddert
Posted
Hey Eduardo, great work on this challenge and congrats on submitting your first solution! You've done a really good job. Here are some pointers after taking a look at your code:
- You've currently got multiple
h1
elements. Although this is valid HTML it's generally still considered a bad practice, as it can cause accessibility issues with the content hierarchy. In this instance, you could use a singleh1
element and then add aspan
inside to separate the text for styling. - I'd recommend avoiding skipping heading levels unnecessarily. This can cause accessibility issues in the content hierarchy for screen reader users. You've jumped straight from a
h1
toh4
inside the cards without using anyh2
orh3
headings. In this challenge, I would put the card headings ash2
elements as that's the next level. - A great next step would be to try making your solution responsive. If you haven't learned this yet, here's a great responsive fundamentals tutorial on Udacity that will help you out.
I hope we can help you reach your goal of becoming a professional front-end developer! Let me know if you have any questions and keep up the great work 🙂