Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS HTML solution

P

@jedcanchola

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I want to become in a front end developer, In order to acomplish that goal I decided to train on html css and javascrip (the classic roadmap), and eventually go and train on a JS framework, I want to know how to reduce my code, the best practices so the code be as good as possible.

Community feedback

T
Matt Studdert 13,611

@mattstuddert

Posted

Hey Eduardo, great work on this challenge and congrats on submitting your first solution! You've done a really good job. Here are some pointers after taking a look at your code:

  • You've currently got multiple h1 elements. Although this is valid HTML it's generally still considered a bad practice, as it can cause accessibility issues with the content hierarchy. In this instance, you could use a single h1 element and then add a span inside to separate the text for styling.
  • I'd recommend avoiding skipping heading levels unnecessarily. This can cause accessibility issues in the content hierarchy for screen reader users. You've jumped straight from a h1 to h4 inside the cards without using any h2 or h3 headings. In this challenge, I would put the card headings as h2 elements as that's the next level.
  • A great next step would be to try making your solution responsive. If you haven't learned this yet, here's a great responsive fundamentals tutorial on Udacity that will help you out.

I hope we can help you reach your goal of becoming a professional front-end developer! Let me know if you have any questions and keep up the great work 🙂

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord