Design comparison
SolutionDesign
Community feedback
- @PhoenixDev22Posted about 2 years ago
Hi sümeyya,
Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:
HTML
- You can use the
<main>landmark to wrap the NFT. using landmarks is important to improve navigation experience on your site for users of assistive technology
- The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..)
for this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use<button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use<a>.
For the same reason, you can use
<a>to wrapEquilibrium #3429 and Jules Wyvern.- The link wrapping the equilibrium image should either have
Sr-onlytext, anaria-labeloralttext that says where that link takes you.
- For any decorative images, each img tag should have empty
alt=""and addaria-hidden="true"attributes to make all web assistive technologies such as screen reader ignore those images in( icon-view, icon-ethereum, icon-clock ).
- Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name
Jules Wyvern. Read more how to write an alt text
- Never use
<div>and<span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.
- For middle part of the card
class="colbody", you can use an unordered list<ul>, in each<li>there should be<img>and<p>. That way you can align them centrally.
- If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<div class="hr"></div>, you can useborder-top:to the avatar's part.
- There are so many ways to do the hover effect on the image, The one I would use is pseudo elements
::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.
Last , there are some unecessary div's need to be removed to obtain a clean code.
Hopefully this feedback helps.
Marked as helpful0 - You can use the
- @VCaramesPosted about 2 years ago
Congrats @kisacasumderler on completing this challenge!
Tips/advice to improve your code.
To make your code semantically correct and reduce clutter, I would set up your HTML code in this manner:
<body> <article> <img src="" alt="" /> <div class="main-text"> <h1></h1> <p></p> </div> <div class="additional-info"> <div class="price"></div> <div class="time"></div> </div> <hr> <div class="author"> <img src="" alt=""> <p></p> </div> </article> </body>Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord