css + html QRcode challenge_my 1st coding challenge

Community feedback

• 

  Vee•240

  @JunasVeePosted over 2 years ago

  Hi Lili!

  It seems like something is wrong when you uploaded your files to Github. The preview link only shows the README.md file's content. What I suggest you do is:

  • Directly and only upload the exact "qr-code-component-main" folder itself or in other words the folder where the index.html file is located/placed instead of the folder that is nesting the index.html's folder with another unnecessary file.

  After you implement this solution, I'm 99.9% certain that your website will work as expected.

  Marked as helpful

  0

  ---

  

  LILI YAO•10

  @LiliYao2022Posted over 2 years ago

  @JunasVee
  Hi Junas,

  Thank you for your suggestion and you are right, I uploaded the folder directly and without knowing it won't work. lol~

  Thanks again, hopefully I will figure it out soon :)

  0

  

  Vee•240

  @JunasVeePosted over 2 years ago

  @LiliYao2022 I'm glad to hear that,

  I've checked your Github repository again, it works as it should but the CSS isn't connected. That's because you put href="./css/style.css" while the CSS file is not in a folder. Here are the things that you can do:

  Change it to either

  • href="style.css"
  • href="./style.css"
  • href="/style.css"
  • href="./qr-code-component-main/css/style.css"

  just figure out which one works, I hope my feedbacks are helpful.

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings LiliYao2022

  Congratulations for taking your first challenge. Here is a few suggestions:

  • your live preview link is not displaying the intended page - the index.html should be in the root folder of your project. Move it to where the readme file is located . Make sure to adjust any links in the index.html after moving it
  • a site is expected to have a heading element - the h1 element is one heading that should be the first heading element. Read more here heading elements

  Marked as helpful

  0