CSS HTML JS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

  • The “icons/images” in this component serve no other purpose then to be decorative; They add no value. There Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Your ratings should have an active state to let users know which rating they have chosen.

  • The proper way to build this challenge is to create a Form and inside of it, the “rating buttons” should be built using an Input Radio (wrap all of them inside a Fieldset), since this will prevent additional buttons from being active at the same time, and it should have a Label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  • Currently, users can submit without selecting a rating. To fix this, you can do one of the following:

  1. Make the “5” rating the default rating.
  2. Create an error message, telling users they need make a section.
  3. Disable the button until a selection is made.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0