Skip to content
Submitted about 2 years ago

CSS HTML FLEX

ifeanyi simon•210
@Simonify30
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Good day bosses all your feedbacks are highly appreciated

Community feedback

  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi ifeanyi simon, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    0
    ifeanyi simon•210
    @Simonify30Posted about 2 years ago

    @AdrianoEscarabote ok tnx boss

    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @Simonify30, Congratulations on completing this challenge!

    Your solution its almost done and I’ve some tips to help you to improve it:

    Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

    I saw that you’ve used flexbox to place the content and create the layout.

    I think the best way to build this component with two columns is by using GRID LAYOUT since it is simpler to manage the columns and then create the media query for mobile. Here’s the steps to create it with grid create the main block to hold all the content (you can use <main> to wrap), set its width as max-width: 900px (it's the container size) and display: grid / grid-template-column: 1fr 1fr(this means that your component will have two columns with 50% of the container width each thats 450px). To manage the column with the text use flexbox and gap to give it the spacing between the texts or use padding-bottom to separate them.

    Then to create the mobile version, all you need to do is to change the container flow vertically with grid-template-column: 1fr.

    ✌️ I hope this helps you and happy coding!

    0
    ifeanyi simon•210
    @Simonify30Posted about 2 years ago

    @correlucas tnx boss i really appreciate your contributions and solution

    0
  • Aatypic•490
    @AatypicPosted about 2 years ago

    Hello and congratulations on your first solution !

    I see you had some issues with the images. So that the two containers are separated

    -If you give a min-height:100vh to your container, it's normal that it's children will be very very tall, in this case this property should be set on the <body>. Now I understand what went wrong with the pictures and why you had to put fixed height a bit of everywhere.

    -In order to further fix things, on <img> you can and you should always use:

    img {
max-width:100%;
display: block;
}

    -Remove the fixed heights and you have one to many container > you can remove the the div.wrapper. the fixed width was also causing the content to split.

    Now the images should fit

    Good luck ✌️

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord